Skip to content

(#342): Cast command back to char to safely made it printable #345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
TheBakedPotato wants to merge 1 commit into
base: main
Choose a base branch
from
Open

(#342): Cast command back to char to safely made it printable #345

TheBakedPotato wants to merge 1 commit into from

Conversation

@TheBakedPotato
Copy link
Collaborator

@TheBakedPotato TheBakedPotato commented Jan 28, 2026

Simple fix of just casting the Command variant back to a char.

@TheBakedPotato TheBakedPotato self-assigned this Jan 28, 2026
@ForrestErickson
Copy link
Collaborator

ForrestErickson commented Jan 29, 2026 •
edited
Loading

Lee's Notes on Testing 20260129 1230 EST

Pulled and switched to branch: bugfix/342-gpad-commands-causing-reboot
Change version for test to: ("FIRMWARE_VERSION", "C.46 "), # bugfix/342-gpad-commands-causing-reboot.
Compile and upload to target Krake.
Tested with "i"
Result: FAILED.

Serial Monitor Dump with "i" command showing reset.

IP Address: (0,0,0,0)
currentlyMuted : 0
interpret Done
dfPlayer.play
0
PlayNotBusyLevel
Guru Meditation Error: Core  1 panic'ed (LoadProhibited). Exception was unhandled.

Core  1 register dump:
PC      : 0x400d78bc  PS      : 0x00060930  A0      : 0x800d7911  A1      : 0x3ffb21b0  
A2      : 0x3ffc3de4  A3      : 0x00000000  A4      : 0x00000010  A5      : 0x0000ff00  
A6      : 0x00ff0000  A7      : 0xff000000  A8      : 0x00000000  A9      : 0x00000007  
A10     : 0x00000000  A11     : 0x3f40f16b  A12     : 0x0000000a  A13     : 0x0000ff00  
A14     : 0x00ff0000  A15     : 0xff000000  SAR     : 0x00000004  EXCCAUSE: 0x0000001c  
EXCVADDR: 0x00000000  LBEG    : 0x4017b160  LEND    : 0x4017b16c  LCOUNT  : 0x00000000  

Backtrace: 0x400d78b9:0x3ffb21b0 0x400d790e:0x3ffb21d0 0x400d7920:0x3ffb21f0 0x400d32bd:0x3ffb2210 0x400d4092:0x3ffb2230 0x400d51a8:0x3ffb2250 0x400d3a44:0x3ffb2270 0x400f2e85:0x3ffb2290
ELF file SHA256: c7adff7250f522d2

Rebooting...
ets Jul 29 2019 12:21:46

rst:0xc (SW_CPU_RESET),boot:0x17 (SPI_FAST_FLASH_BOOT)
configsip: 0, SPIWP:0xee
clk_drv:0x00,q_drv:0x00,d_drv:0x00,cs0_drv:0x00,hd_drv:0x00,wp_drv:0x00
mode:DIO, clock div:2
load:0x3fff0030,len:1184
load:0x40078000,len:13232
load:0x40080400,len:3028
entry 0x400805e4
===================================
PubInv 
KRAKE_
GPAD_API C.46 
Builtin ESP32 MAC Address: 
Alarm Topic: 
Broker: public.cloud.shiftr.io
Compiled at: Jan 29 2026 12:32:01
GNU Affero General Public License, version 3 
===================================

Testing on ESP32 Dev Kit1

Summary, same results when sending "i" the firmware reset.
In addition on the Dev Kit1 there are messages about the MUTE and ENCODER switches being pressed and held.

Serial Monitor Dump

A2 : 0x3ffc3de4 A3 : 0x00000009 A4 : 0x0000000a A5 : 0x00000000
A6 : 0x00000003 A7 : 0x00060023 A8 : 0x800f10f5 A9 : 0x3ffb21c0
A10 : 0x00000000 A11 : 0x3f40141f A12 : 0xb1a24b4a A13 : 0x3ffc4c18
A14 : 0x00000001 A15 : 0x3ffb0320 SAR : 0x00000004 EXCCAUSE: 0x0000001c
EXCVADDR: 0x00000000 LBEG : 0x4008a5f5 LEND : 0x4008a605 LCOUNT : 0xffffffff

Backtrace: 0x400d77bd:0x3ffb21f0 0x400d32cb:0x3ffb2210 0x400d4092:0x3ffb2230 0x400d51a8:0x3ffb2250 0x400d3a44:0x3ffb2270 0x400f2e85:0x3ffb2290

ELF file SHA256: 6291dfe2c5d734c3

Rebooting

ets Jun  8 2016 00:22:57 
rst:0xc (SW_CPU_RESET),boot:0x13 (SPI_FAST_FLASH_BOOT)
configsip: 0, SPIWP:0xee
clk_drv:0x00,q_drv:0x00,d_drv:0x00,cs0_drv:0x00,hd_drv:0x00,wp_drv:0x00
mode:DIO, clock div:2
load:0x3fff0030,len:1184
load:0x40078000,len:13232
load:0x40080400,len:3028
entry 0x400805e4
===================================
PubInv 
KRAKE_
GPAD_API C.46 
Builtin ESP32 MAC Address: 
Alarm Topic: 
Broker: public.cloud.shiftr.io
Compiled at: Jan 29 2026 12:40:24
GNU Affero General Public License, version 3 
===================================

Note on testing on ESP32 DEV Kit1.
Connect GPIO 34 and GPIO35 through 10K resistor to VIN and retest.
This eliminates the Button hold messages.

The "i" command still causes a reset.

Guru Meditation Error: Core  1 panic'ed (LoadProhibited). Exception was unhandled.

Core  1 register dump:
PC      : 0x400d77c0  PS      : 0x00060930  A0      : 0x800d32ce  A1      : 0x3ffb21f0  
A2      : 0x3ffc3de4  A3      : 0x00000009  A4      : 0x0000000a  A5      : 0x00000000  
A6      : 0x00ff0000  A7      : 0xff000000  A8      : 0x800f10f5  A9      : 0x3ffb21c0  
A10     : 0x00000000  A11     : 0x3f40141f  A12     : 0x6cbfbabb  A13     : 0x3ffc4c18  
A14     : 0x00ff0000  A15     : 0xff000000  SAR     : 0x00000004  EXCCAUSE: 0x0000001c  
EXCVADDR: 0x00000000  LBEG    : 0x4008a5f5  LEND    : 0x4008a605  LCOUNT  : 0xffffffff  

Backtrace: 0x400d77bd:0x3ffb21f0 0x400d32cb:0x3ffb2210 0x400d4092:0x3ffb2230 0x400d51a8:0x3ffb2250 0x400d3a44:0x3ffb2270 0x400f2e85:0x3ffb2290

ELF file SHA256: 6291dfe2c5d734c3

Rebooting...
ets Jun  8 2016 00:22:57

rst:0xc (SW_CPU_RESET),boot:0x13 (SPI_FAST_FLASH_BOOT)
configsip: 0, SPIWP:0xee
clk_drv:0x00,q_drv:0x00,d_drv:0x00,cs0_drv:0x00,hd_drv:0x00,wp_drv:0x00
mode:DIO, clock div:2
load:0x3fff0030,len:1184
load:0x40078000,len:13232
load:0x40080400,len:3028
entry 0x400805e4
===================================
PubInv 
KRAKE_
GPAD_API C.46 
Builtin ESP32 MAC Address: 
Alarm Topic: 
Broker: public.cloud.shiftr.io
Compiled at: Jan 29 2026 12:40:24
GNU Affero General Public License, version 3 
===================================

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nk25719 nk25719 Awaiting requested review from nk25719

Assignees

@TheBakedPotato TheBakedPotato

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@TheBakedPotato @ForrestErickson